benn/lumiera_
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remote unnecessary calls to llist_unlink() insert is enough

Browse source
This commit is contained in:
Michael Ploujnikov 2010-01-12 07:39:12 -05:00
parent 49da609e80
commit ecbcfdefd7
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/backend/threadpool.c
View file

@ -115,12 +115,13 @@ lumiera_threadpool_acquire_thread(enum lumiera_thread_class kind,
} }
// use an existing thread, pick the first one // use an existing thread, pick the first one
// remove it from the pool's list // remove it from the pool's list
ret = (LumieraThread)(llist_unlink (llist_head (&threadpool.pool[kind].idle_list))); ret = (LumieraThread) (llist_head (&threadpool.pool[kind].idle_list));
ENSURE (ret, "did not find a valid thread"); ENSURE (ret, "did not find a valid thread");
REQUIRE (ret->state == LUMIERA_THREADSTATE_IDLE, "trying to return a non-idle thread (state=%s)", lumiera_threadstate_names[ret->state]); REQUIRE (ret->state == LUMIERA_THREADSTATE_IDLE, "trying to return a non-idle thread (state=%s)", lumiera_threadstate_names[ret->state]);
// move thread to the working_list
llist_insert_head (&threadpool.pool[kind].working_list, ret); llist_insert_head (&threadpool.pool[kind].working_list, ret);
threadpool.pool[kind].working_thread_count++; threadpool.pool[kind].working_thread_count++;
@ -153,7 +154,7 @@ lumiera_threadpool_release_thread(LumieraThread thread)
{ {
thread->state = LUMIERA_THREADSTATE_IDLE; thread->state = LUMIERA_THREADSTATE_IDLE;
REQUIRE (llist_is_empty (&thread->node), "thread already belongs to some list"); REQUIRE (llist_is_empty (&thread->node), "thread already belongs to some list");
llist_unlink (&thread); // remove thread from the working_list // move thread to the idle_list
llist_insert_head (&threadpool.pool[thread->kind].idle_list, &thread->node); llist_insert_head (&threadpool.pool[thread->kind].idle_list, &thread->node);
threadpool.pool[thread->kind].working_thread_count--; threadpool.pool[thread->kind].working_thread_count--;