benn/lumiera_documentation
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

DI: change to heap allocation for singletons

Browse source 
up to now we used placement into a static buffer.
While this approach is somewhat cool, I can't see much practical benefit anymore,
given that we use an elaborate framework which rules out the use of Meyers Singleton.
And given that with C++11 we're able just to use std::unique_ptr to do all work.

Moreover, the intended configurability will become much simpler by relying
on a _closure_ to produce a heap-allocated instance for all cases likewise.

The only possible problem I can see is that critical infrastructure might
rely on failsafe creation of some singleton. Up to now this scenario
remains theoretical however
This commit is contained in:
Fischlurch 2018-03-17 23:41:56 +01:00
parent e393d44e92
commit eebe31aa7e
2 changed files with 48 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
research/try.cpp
View file

@ -56,6 +56,7 @@ typedef unsigned int uint;
#include <boost/noncopyable.hpp> #include <boost/noncopyable.hpp>
#include <functional> #include <functional>
#include <type_traits> #include <type_traits>
#include <memory>
#define SHOW_TYPE(_TY_) \ #define SHOW_TYPE(_TY_) \
@ -75,39 +76,22 @@ using lib::meta::enable_if;
class InstanceHolder class InstanceHolder
: boost::noncopyable : boost::noncopyable
{ {
/** storage for the service instance */ std::unique_ptr<TAR> instance_;
char buff_[sizeof(TAR)];
bool alive_ = false;
public: public:
~InstanceHolder()
{
if (alive_)
try {
alive_ = false;
reinterpret_cast<TAR&> (buff_). ~TAR();
}
catch(...)
{ // no logging since we might be in static shutdown
lumiera_error(); // reset errorflag
}
}
TAR* TAR*
buildInstance() buildInstance()
{ {
if (alive_) if (instance_)
throw error::Fatal("Attempt to double-create a singleton service. " throw error::Fatal("Attempt to double-create a singleton service. "
"Either the application logic, or the compiler " "Either the application logic, or the compiler "
"or runtime system is seriously broken" "or runtime system is seriously broken"
,error::LUMIERA_ERROR_LIFECYCLE); ,error::LUMIERA_ERROR_LIFECYCLE);
// place new instance into embedded buffer // place new instance into embedded buffer
TAR* newInstance = new(&buff_) TAR (); instance_.reset (new TAR{});
alive_ = true; return instance_.get();
return newInstance;
} }
}; };
@ -232,7 +216,7 @@ main (int, char**)
SHOW_EXPR( checksum ); SHOW_EXPR( checksum );
Depend<Dum> dumm; Depend<Dum> dumm;
Depend<Dum>::factory = [](){ return nullptr; }; // Depend<Dum>::factory = [](){ return nullptr; };
SHOW_EXPR( dumm().probe() ); SHOW_EXPR( dumm().probe() );

43
wiki/thinkPad.ichthyo.mm
View file

@ -26993,7 +26993,48 @@
<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1521169130251" ID="ID_1252056818" MODIFIED="1521169146081" TEXT="Zugang f&#xfc;r DependInject"> <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1521169130251" ID="ID_1252056818" MODIFIED="1521169146081" TEXT="Zugang f&#xfc;r DependInject">
<icon BUILTIN="flag-yellow"/> <icon BUILTIN="flag-yellow"/>
</node> </node>
<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1521254014422" ID="ID_961824675" MODIFIED="1521254035254" TEXT="Meyers Singleton oder explizit ausprogrammieren?"> <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1521324229082" ID="ID_1398878858" MODIFIED="1521324233702" TEXT="Storage">
<icon BUILTIN="flag-yellow"/>
<node CREATED="1521324240124" ID="ID_1099103129" MODIFIED="1521324253936">
<richcontent TYPE="NODE"><html>
<head>
</head>
<body>
<p>
statische Storage ist <i>irgendwie cool</i>
</p>
</body>
</html>
</richcontent>
</node>
<node CREATED="1521324275919" ID="ID_1710451095" MODIFIED="1521324497413" TEXT="sehe aber auch keinen wirklichen Vorteil">
<node CREATED="1521324529228" ID="ID_1786667023" MODIFIED="1521324543094" TEXT="man mu&#xdf; sich nicht um die de-Allokation k&#xfc;mmern"/>
<node CREATED="1521324554465" ID="ID_1577416641" MODIFIED="1521324568043" TEXT="Storage ist garantiert vorhanden, kein out-of-Memory"/>
<node CREATED="1521324668449" ID="ID_1013908061" MODIFIED="1521324682434" TEXT="Meyers Singleton ist elegant und schnell"/>
</node>
<node CREATED="1521324321601" ID="ID_805959606" MODIFIED="1521324477609" TEXT="Nachteil: Storage ist stets belegt, auch wenn nicht notwendig">
<richcontent TYPE="NOTE"><html>
<head>
</head>
<body>
<p>
das gilt im Besonderen f&#252;r eine default-Storage als Singleton.
</p>
<p>
Wofern wir dynamisch konfigurieren (wollen), mu&#223; dieser Default stets statisch bereitgestellt werden,
</p>
<p>
selbst wenn die dynamische Konfiguration so angelegt ist, da&#223; die Storage nie ben&#246;tigt wird
</p>
</body>
</html>
</richcontent>
</node>
<node CREATED="1521324883035" ID="ID_1438637057" MODIFIED="1521324896069" TEXT="Heap-Allokation k&#xf6;nnte insgesamt einfacher sein"/>
</node>
<node COLOR="#338800" CREATED="1521254014422" ID="ID_961824675" MODIFIED="1521324200616" TEXT="Meyers Singleton oder explizit ausprogrammieren?">
<icon BUILTIN="help"/> <icon BUILTIN="help"/>
<node CREATED="1521303577633" ID="ID_1665490706" MODIFIED="1521303615967" TEXT="das w&#xe4;re die &quot;Standard-L&#xf6;sung&quot; f&#xfc;r Singletons"/> <node CREATED="1521303577633" ID="ID_1665490706" MODIFIED="1521303615967" TEXT="das w&#xe4;re die &quot;Standard-L&#xf6;sung&quot; f&#xfc;r Singletons"/>
<node CREATED="1521303616675" ID="ID_135579041" MODIFIED="1521303721048" TEXT="hier aber nicht sinnvoll..."> <node CREATED="1521303616675" ID="ID_135579041" MODIFIED="1521303721048" TEXT="hier aber nicht sinnvoll...">