ichthyo/LUMIERA.clone
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UI-Dispatch: remove unnecessary intermediary function

Browse source 
...since the generateErrorResponse() in UiDispatcher already adds some
explanatory boilerplate to the message; and we can not do anything beyond
publishing the message into the UI message box
This commit is contained in:
Fischlurch 2017-08-31 14:53:15 +02:00
parent 526fd3ca16
commit 29246621df
2 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/gui/notification-service.cpp
View file

@ -85,12 +85,6 @@ namespace gui {
});
}
void
NotificationService::showErrorUI (string errorMsg)
{
UNIMPLEMENTED ("forward error message to the error log");
}
void
NotificationService::displayInfo (NotifyLevel severity, string const& text)
@ -130,7 +124,7 @@ namespace gui {
{
NOTICE (gui, "@GUI: shutdown triggered with explanation '%s'....", cStr(cause));
displayInfo (NOTE_ERROR, cause);
dispatch_->event ([=]()
dispatch_->event ([this]()
{
uiManager_.terminateUI();
});
@ -275,15 +269,16 @@ namespace gui {
/**
* When started, NotificationService connects to the [UI-Bus](ui-bus.hpp) via
* the provided connection. This is a simple, unidirectional up-link connection,
* without actively adding NotificationService into the routing tables in [Nexus].
* Yet this simple connection is sufficient to implement this service by talking
* to other facilities within the UI layer.
* When started, NotificationService connects to the [UI-Bus](ui-bus.hpp) via the provided connection.
* This is a simple, unidirectional up-link connection, without actively adding NotificationService
* into the routing tables in [Nexus]. Yet this simple connection is sufficient to implement this
* service by talking to other facilities within the UI layer.
* @remark internally this service relies on a UiDispatcher queue to hand over any invocations
* into the GTK event loop thread.
*/
NotificationService::NotificationService (ctrl::BusTerm& upLink, ctrl::UiManager& uiManager)
: BusTerm{lib::idi::EntryID<NotificationService>{}, upLink}
, dispatch_{new UiDispatcher{[this](string msg){ showErrorUI(msg); }}}
, dispatch_{new UiDispatcher{[this](string msg){ displayInfo (NOTE_ERROR, msg); }}}
, uiManager_{uiManager}
, implInstance_(this,_instance)
, serviceInstance_( LUMIERA_INTERFACE_REF (lumieraorg_GuiNotification, 0,lumieraorg_GuiNotificationService))

1
src/gui/notification-service.hpp
View file

@ -91,7 +91,6 @@ namespace gui {
ctrl::UiManager& uiManager_;
void dispatchMsg (ID, lib::diff::GenNode&&);
void showErrorUI (string errorMsg);
/* === Interface Lifecycle === */