From 5aa28626ad2ac5344ec1747cebe89f4df77b1347 Mon Sep 17 00:00:00 2001
From: Ichthyostega <prg@ichthyostega.de>
Date: Wed, 3 Oct 2018 19:33:28 +0200
Subject: [PATCH] NotificationDisplay: function to demote error entries into
 warnings

...and remove them from the mark-index for special handling
---
 src/gui/widget/error-log-display.hpp | 13 +++++++++-
 wiki/thinkPad.ichthyo.mm             | 38 ++++++++++++++--------------
 2 files changed, 31 insertions(+), 20 deletions(-)

diff --git a/src/gui/widget/error-log-display.hpp b/src/gui/widget/error-log-display.hpp
index 526013c69..3f5d316b1 100644
--- a/src/gui/widget/error-log-display.hpp
+++ b/src/gui/widget/error-log-display.hpp
@@ -238,10 +238,21 @@ namespace widget {
           addInfo (_Fmt{_("───════ %d old log lines removed ════───\n")} % (oldLines-newLines));
         }
       
+      
+      /** visit all errors and downgrade the markup; discard all bookmarks */
       void
       turnError_into_InfoMsg()
         {
-          UNIMPLEMENTED ("visit all errors and downgrade the markup; discard all bookmarks");
+          auto buff = textLog_.get_buffer();
+          for (Entry& entry : errorMarks_)
+            {
+              auto begin = entry.first->get_iter();
+              auto end = entry.second->get_iter();
+              
+              buff->remove_tag_by_name(uString{TAG_ERROR}, begin,end);
+              buff->apply_tag_by_name (uString{TAG_WARN}, begin,end);
+            }
+          errorMarks_.clear();
         }
       
       void
diff --git a/wiki/thinkPad.ichthyo.mm b/wiki/thinkPad.ichthyo.mm
index 106e5c755..f582a7386 100644
--- a/wiki/thinkPad.ichthyo.mm
+++ b/wiki/thinkPad.ichthyo.mm
@@ -2072,9 +2072,9 @@
 </node>
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1534725152139" ID="ID_887758432" MODIFIED="1538263469668" TEXT="addError">
 <icon BUILTIN="pencil"/>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1534725422454" ID="ID_1459967459" MODIFIED="1538263469668" TEXT="spezieller Markup">
+<node COLOR="#338800" CREATED="1534725422454" ID="ID_1459967459" MODIFIED="1538587727278" TEXT="spezieller Markup">
 <linktarget COLOR="#a9b4c1" DESTINATION="ID_1459967459" ENDARROW="Default" ENDINCLINATION="-73;-253;" ID="Arrow_ID_424075973" SOURCE="ID_580465154" STARTARROW="None" STARTINCLINATION="225;0;"/>
-<icon BUILTIN="flag-yellow"/>
+<icon BUILTIN="button_ok"/>
 <node COLOR="#338800" CREATED="1537571906634" ID="ID_1839759637" MODIFIED="1538263469668" TEXT="Tags anlegen">
 <icon BUILTIN="button_ok"/>
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1537571917625" ID="ID_1900926418" MODIFIED="1538263469668" TEXT="k&#xe4;ren: CSS?">
@@ -2112,12 +2112,12 @@
 <node COLOR="#338800" CREATED="1537571949893" ID="ID_328949056" MODIFIED="1538263469669" TEXT="Tags zuweisen">
 <icon BUILTIN="button_ok"/>
 </node>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1537571956436" ID="ID_1806243350" MODIFIED="1538263469669" TEXT="Tags entfernen">
+<node COLOR="#338800" CREATED="1537571956436" ID="ID_1806243350" MODIFIED="1538587722314" TEXT="Tags entfernen">
 <linktarget COLOR="#a9b4c1" DESTINATION="ID_1806243350" ENDARROW="Default" ENDINCLINATION="294;-15;" ID="Arrow_ID_52974407" SOURCE="ID_383201596" STARTARROW="None" STARTINCLINATION="294;-15;"/>
-<icon BUILTIN="flag-yellow"/>
+<icon BUILTIN="button_ok"/>
 </node>
 </node>
-<node COLOR="#338800" CREATED="1534725501467" ID="ID_1420459325" MODIFIED="1538586532645" TEXT="Bookmark speichern">
+<node COLOR="#338800" CREATED="1534725501467" FOLDED="true" ID="ID_1420459325" MODIFIED="1538587929492" TEXT="Bookmark speichern">
 <icon BUILTIN="button_ok"/>
 <node COLOR="#435e98" CREATED="1537535919147" ID="ID_1338221225" MODIFIED="1538263469669" TEXT="Technologie">
 <icon BUILTIN="info"/>
@@ -2243,14 +2243,14 @@
 <icon BUILTIN="button_ok"/>
 </node>
 </node>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1534725160618" ID="ID_1981616896" MODIFIED="1538263469669" TEXT="turnError_into_InfoMsg">
-<icon BUILTIN="flag-yellow"/>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1534725575098" ID="ID_383201596" MODIFIED="1538263469669" TEXT="Markup reduzieren">
+<node COLOR="#338800" CREATED="1534725160618" ID="ID_1981616896" MODIFIED="1538587717273" TEXT="turnError_into_InfoMsg">
+<icon BUILTIN="button_ok"/>
+<node COLOR="#338800" CREATED="1534725575098" ID="ID_383201596" MODIFIED="1538587760128" TEXT="Markup reduzieren">
 <arrowlink DESTINATION="ID_1806243350" ENDARROW="Default" ENDINCLINATION="294;-15;" ID="Arrow_ID_52974407" STARTARROW="None" STARTINCLINATION="294;-15;"/>
-<icon BUILTIN="flag-yellow"/>
+<icon BUILTIN="button_ok"/>
 </node>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1534725587112" ID="ID_31905080" MODIFIED="1538263469669" TEXT="Bookmarks entfernen">
-<icon BUILTIN="flag-yellow"/>
+<node COLOR="#338800" CREATED="1534725587112" ID="ID_31905080" MODIFIED="1538587763137" TEXT="Bookmarks entfernen">
+<icon BUILTIN="button_ok"/>
 </node>
 </node>
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1534725180543" ID="ID_1442607312" MODIFIED="1538263469669" TEXT="triggerFlash">
@@ -2669,8 +2669,8 @@
 </node>
 </node>
 </node>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1533689146501" ID="ID_1371087868" MODIFIED="1538263469671" TEXT="bei Bedarf anzeigen">
-<icon BUILTIN="flag-yellow"/>
+<node COLOR="#338800" CREATED="1533689146501" ID="ID_1371087868" MODIFIED="1538587918512" TEXT="bei Bedarf anzeigen">
+<icon BUILTIN="button_ok"/>
 <node COLOR="#338800" CREATED="1534636343111" ID="ID_1922277957" MODIFIED="1538263469671" TEXT="ebenfalls explizit zu bauen">
 <icon BUILTIN="button_ok"/>
 <node CREATED="1534636352398" ID="ID_435790811" MODIFIED="1538263469671" TEXT="&#xe4;hnliche Lage wie bei Destroy">
@@ -2807,16 +2807,16 @@
 <icon BUILTIN="info"/>
 </node>
 </node>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1534120150464" ID="ID_1675673289" MODIFIED="1538263469673" TEXT="doClearErr()">
-<icon BUILTIN="pencil"/>
+<node COLOR="#338800" CREATED="1534120150464" ID="ID_1675673289" MODIFIED="1538587773087" TEXT="doClearErr()">
+<icon BUILTIN="button_ok"/>
 <node CREATED="1534120150465" ID="ID_1858186015" MODIFIED="1538263469673" TEXT="&quot;clear error state. If widget exists, turn all error entries into mere information entries&quot;">
 <icon BUILTIN="info"/>
 </node>
 </node>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1537531617621" ID="ID_447071799" MODIFIED="1538263469673" TEXT="doMark()">
-<icon BUILTIN="flag-yellow"/>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1537531624828" ID="ID_52936917" MODIFIED="1538263469673" TEXT="Spezialbehandlung + Chain, um die Warnungs State-marks abzugreifen">
-<icon BUILTIN="flag-yellow"/>
+<node COLOR="#338800" CREATED="1537531617621" ID="ID_447071799" MODIFIED="1538587782757" TEXT="doMark()">
+<icon BUILTIN="button_ok"/>
+<node COLOR="#338800" CREATED="1537531624828" ID="ID_52936917" MODIFIED="1538587791541" TEXT="Spezialbehandlung + Chain, um die Warnungs State-marks abzugreifen">
+<icon BUILTIN="button_ok"/>
 </node>
 </node>
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1534120150465" ID="ID_1862649971" MODIFIED="1538263469673" TEXT="doFlash()">