From 60d40a6a6e7acd71dbc7496ea07993535525aa5a Mon Sep 17 00:00:00 2001
From: Ichthyostega <prg@ichthyostega.de>
Date: Wed, 14 Feb 2018 04:42:19 +0100
Subject: [PATCH] LocationSolver: concept for standard usage situation test
 coverage

...using a fixed set of rules this time,
while injecting a different (simulated) UI tree for each testcase
---
 .../gui/interact/ui-location-solver-test.cpp  | 44 +++++++++++++++++--
 wiki/thinkPad.ichthyo.mm                      | 34 +++++++++++---
 2 files changed, 67 insertions(+), 11 deletions(-)

diff --git a/tests/gui/interact/ui-location-solver-test.cpp b/tests/gui/interact/ui-location-solver-test.cpp
index 5b08a494a..cb7753a81 100644
--- a/tests/gui/interact/ui-location-solver-test.cpp
+++ b/tests/gui/interact/ui-location-solver-test.cpp
@@ -348,19 +348,53 @@ namespace test {
         }
       
       
+      /** @test emulate the relevant standard situations of view location resolution.
+       * The typical location specifications to be expected in practice can be subsumed
+       * under a small selection of standard situations; this test demonstrates how these
+       * are triggered by specific tree configurations in a (hopefully) obvious way.
+       * 
+       * For this purpose, we create a single set of location clauses here, but evaluate them
+       * each time against different (simulated) UI tree configurations to verify that the expected
+       * resulting location is actually derived in all those cases.
+       */
       void
       verify_standardSituations()
         {
-          UNIMPLEMENTED ("emulate the relevant standard situations of view location resolution");
+          // Test Fixture: a solver which always queries the current state of a (simulated) uiTree
+          Rec uiTree;
+          std::unique_ptr<GenNodeLocationQuery> query;
+          UILocationSolver solver{[&]() -> GenNodeLocationQuery&
+                                     {
+                                       query.reset (new GenNodeLocationQuery(uiTree));
+                                       return *query;
+                                     }};
+          
+          // Test Fixture: common set of location clauses
+          LocationRule location{UICoord().persp("edit").panel("viewer")};
+          location.append      (UICoord::currentWindow().panel("viewer"));
+          location.append      (UICoord().panel("viewer"));
+          location.append      (UICoord().tab("type(Asset)"));
+          location.append      (UICoord().persp("asset").view("asset"));
+          location.append      (UICoord().view("asset").tab("type(Asset)").create());
+          location.append      (UICoord::currentWindow().panel("viewer").create());
+          location.append      (UICoord::window("meta").panel("infobox").view("inspect").create());
+          
+          cout << location << endl;
+          
           
           /* === match by perspective + panel === */
+          uiTree = MakeRec()
+                     .set("win"
+                         , MakeRec()
+                             .type("edit")
+                             .set ("viewer", MakeRec()));
+          cout << solver.solve (location, UIC_VIEW, "videoViewer") <<endl;
+          cout << solver.solve (location, UIC_TAB, "clipAssets") <<endl;
           
-          /* === match by window + panel === */
+          /* === match by generic window + panel === */
           
           /* === match by panel alone === */
           
-          /* === match on create clause with generic window spec and panel === */
-          
           
           /* === wildcard match on view === */
           
@@ -371,6 +405,8 @@ namespace test {
           
           /* === unsatisfied create clause with wildcard === */
           
+          /* === match on create clause with generic window spec and panel === */
+          
           /* === completely uncovered create-from-scratch === */
           
         }
diff --git a/wiki/thinkPad.ichthyo.mm b/wiki/thinkPad.ichthyo.mm
index 249f56236..0cb7fe750 100644
--- a/wiki/thinkPad.ichthyo.mm
+++ b/wiki/thinkPad.ichthyo.mm
@@ -10950,22 +10950,39 @@
 </node>
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1517506289222" ID="ID_1250541940" MODIFIED="1518573725304" TEXT="praktische Standard-F&#xe4;lle">
 <icon BUILTIN="pencil"/>
+<node CREATED="1518575724831" ID="ID_712009155" MODIFIED="1518579539092" TEXT="Idee">
+<icon BUILTIN="idea"/>
+<node CREATED="1518575730894" ID="ID_24825251" MODIFIED="1518575750656">
+<richcontent TYPE="NODE"><html>
+  <head>
+    
+  </head>
+  <body>
+    <p>
+      nur <i>einen Satz</i>&#160;Klauseln
+    </p>
+  </body>
+</html>
+</richcontent>
+</node>
+<node CREATED="1518575751651" ID="ID_1423547228" MODIFIED="1518575765468" TEXT="stattdessen den Test-&quot;Baum&quot; variieren"/>
+<node CREATED="1518575766889" ID="ID_1639479655" MODIFIED="1518575777979" TEXT="damit die Situationen der realen Regeln nachbilden"/>
+<node CREATED="1518575779991" ID="ID_1194432520" MODIFIED="1518575791081" TEXT="und beweisen, da&#xdf; die Ergebnisse eindeutig sind"/>
+</node>
+<node COLOR="#338800" CREATED="1518579541832" ID="ID_512680632" MODIFIED="1518579550376" TEXT="flexibles Test-Setup hierf&#xfc;r">
+<icon BUILTIN="button_ok"/>
+</node>
 <node CREATED="1518221768370" ID="ID_958994214" MODIFIED="1518487921072" TEXT="match by">
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223023735" ID="ID_1788599676" MODIFIED="1518487921072" TEXT="pespective + panel">
 <icon BUILTIN="flag-yellow"/>
 </node>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223029399" ID="ID_1184092341" MODIFIED="1518487921072" TEXT="window + panel">
+<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223029399" ID="ID_1184092341" MODIFIED="1518574786042" TEXT="generic window + existing panel">
 <icon BUILTIN="flag-yellow"/>
 </node>
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223039229" ID="ID_427870686" MODIFIED="1518487921072" TEXT="panel alone">
 <icon BUILTIN="flag-yellow"/>
 </node>
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223044301" ID="ID_1476637837" MODIFIED="1518487921072" TEXT="generic window + panel create">
-<icon BUILTIN="flag-yellow"/>
-</node>
-</node>
-<node CREATED="1518223077376" ID="ID_586407261" MODIFIED="1518487921072" TEXT="match">
-<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223101637" ID="ID_481219776" MODIFIED="1518487921072" TEXT="wildcard view">
+<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223101637" ID="ID_481219776" MODIFIED="1518579487507" TEXT="wildcard view + specific tab">
 <icon BUILTIN="flag-yellow"/>
 </node>
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223107508" ID="ID_254700276" MODIFIED="1518487921072" TEXT="wildcard panel + view appended">
@@ -10979,6 +10996,9 @@
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223149750" ID="ID_1733413613" MODIFIED="1518487921072" TEXT="on wildcard fail">
 <icon BUILTIN="flag-yellow"/>
 </node>
+<node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223044301" ID="ID_1476637837" MODIFIED="1518579513685" TEXT="generic window + panel create">
+<icon BUILTIN="flag-yellow"/>
+</node>
 <node BACKGROUND_COLOR="#eee5c3" COLOR="#990000" CREATED="1518223201375" ID="ID_1794858276" MODIFIED="1518487921072" TEXT="complete create">
 <icon BUILTIN="flag-yellow"/>
 </node>