From aac9ee2934046f3d7de90efab7897a469a0fb5e9 Mon Sep 17 00:00:00 2001 From: Ichthyostega Date: Sat, 15 Nov 2025 02:00:11 +0100 Subject: [PATCH] Bugfix: uninitialised stack-memory used in test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ...this bug was spotted as the test failed reproducibly when built with `-fstack-protector-strong` — which adds additional "canary" markers to some kinds of problematic stack storage; this seemed to have the effect that now the second test uses exactly the same location as the preceding test, and thus finds valid data in the newly created work buffers. There is no reason for using uninitialised storage in this test (I can recall that I wanted to build a generic helper and intended to use that as ''virtual overlay'' over existing memory — but that usage never took place, and the `struct Buffer` is not a general-purpose tool now, but only made for this specific test. Thus memory can be easily zero-initialised. --- tests/core/steam/engine/node-devel-test.cpp | 4 +- wiki/thinkPad.ichthyo.mm | 258 +++++++++++++++++++- 2 files changed, 251 insertions(+), 11 deletions(-) diff --git a/tests/core/steam/engine/node-devel-test.cpp b/tests/core/steam/engine/node-devel-test.cpp index a76752afb..3c20eeeac 100644 --- a/tests/core/steam/engine/node-devel-test.cpp +++ b/tests/core/steam/engine/node-devel-test.cpp @@ -26,9 +26,11 @@ #include "lib/random.hpp" #include +#include using lib::zip; using lib::izip; +using std::array; using std::vector; using std::make_tuple; using lib::test::showType; @@ -45,7 +47,7 @@ namespace test { : util::NonCopyable { alignas(TestFrame) - std::byte storage[sizeof(TestFrame)]; + array storage{}; //zero-init operator TestFrame* () { return std::launder (reinterpret_cast (&storage)); } TestFrame* operator->() { return std::launder (reinterpret_cast (&storage)); } diff --git a/wiki/thinkPad.ichthyo.mm b/wiki/thinkPad.ichthyo.mm index b567c5944..771cdcc08 100644 --- a/wiki/thinkPad.ichthyo.mm +++ b/wiki/thinkPad.ichthyo.mm @@ -166384,8 +166384,12 @@ that situation will improve in forseeable future. - + + + + + @@ -166447,6 +166451,19 @@ that situation will improve in forseeable future. + + + + +

+ DEB-Paket: direkt <v%(version)s>-Tag von master verwenden +

+ + + + + + @@ -169268,6 +169285,9 @@ that situation will improve in forseeable future. + + + @@ -169792,6 +169812,7 @@ actively maintained upstream. Please remove gdl from Debian.

+ @@ -169951,7 +169972,7 @@ actively maintained upstream. Please remove gdl from Debian. - + @@ -178388,6 +178409,10 @@ Since then others have made contributions, see the log for the history. + + + + @@ -178512,6 +178537,7 @@ Since then others have made contributions, see the log for the history. + @@ -178951,13 +178977,14 @@ Since then others have made contributions, see the log for the history. - + - + + @@ -178965,7 +178992,7 @@ Since then others have made contributions, see the log for the history. - + @@ -179124,7 +179151,7 @@ Since then others have made contributions, see the log for the history. - + @@ -179494,7 +179521,7 @@ Since then others have made contributions, see the log for the history. - + @@ -179532,7 +179559,7 @@ Since then others have made contributions, see the log for the history. - + @@ -179728,6 +179755,7 @@ Since then others have made contributions, see the log for the history. + @@ -179933,6 +179961,7 @@ Since then others have made contributions, see the log for the history. + @@ -180049,7 +180078,7 @@ Since then others have made contributions, see the log for the history. - + @@ -180162,6 +180191,7 @@ Since then others have made contributions, see the log for the history. + @@ -180271,8 +180301,216 @@ Since then others have made contributions, see the log for the history. - + + + + + + + + +

+ Zehn Jahre Reise ins Ungewisse.... +

+
    +
  • + jetzt auf Debian/Trixie angekommen und C++23 +
    • +
  • + mitten im »Playback Vertical Slice« +
    • +
+ + + + + + + + + + + +
    +
  • + master fungiert direkt als upstream-Branch +
    • +
  • + das Versionsschema angepaßt: upstream-tag = v%(version)s +
    • +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
    +
  • + git clone in ein Unterverzeichnis vom Paketverzeichnis +
    • +
  • + Paketverzeichnis in den Container gemounted
    + + 
    podman run -v /Werk/Gang/pack:/pack -it ichthyo/pack-debian-trixie-20250317
    +
    • +
  • + im Container.... +
    • +
      +
    • + (ggfs dort equivs installieren) +
      • +
    • + cd /pack +
      • +
    • + mk-build-dep --install --remove +
      • +
    • + gbp buildpackage --git-tag +
      • +
    +
+ + + + + + + +

+ Vorbereitung: +

+

+ ./build-pack-dock debian:trixie-2025#### +

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +