diff --git a/src/proc/control/command-invocation.hpp b/src/proc/control/command-invocation.hpp index fd4ee784a..da56f031a 100644 --- a/src/proc/control/command-invocation.hpp +++ b/src/proc/control/command-invocation.hpp @@ -105,6 +105,9 @@ namespace control { * In this case, we allow any invocation call to compile, * but the command will reject unsuitable signatures * at runtime, when fetching the operation functor. + * @remarks actually this kind of invocation is the default case, + * since commands are defined statically at application start-up + * and invoked via the UI-Bus by command-ID */ struct RuntimeCheckedCommandInvoker { @@ -192,17 +195,6 @@ namespace control { - template - inline - com::CommandInvoker - invoke (SIG& operation_func) - { - Command command = Command::get ((FuncPtr)&operation_func); - ASSERT (command); - return com::CommandInvoker (command); - } - - inline com::RuntimeCheckedCommandInvoker invoke (Symbol cmdID) diff --git a/src/proc/control/command-registry.hpp b/src/proc/control/command-registry.hpp index 02dfe6fa0..0830198af 100644 --- a/src/proc/control/command-registry.hpp +++ b/src/proc/control/command-registry.hpp @@ -206,7 +206,7 @@ namespace control { /** search the command index for a definition * @param cmdInstance using the definition to look up * @return the ID used to register this definition - * or \c NULL in case of an "anonymous" command */ + * or `NULL` in case of an "anonymous" command */ Symbol findDefinition (Command const& cmdInstance) const { diff --git a/src/proc/control/command.cpp b/src/proc/control/command.cpp index d99d1821f..e266da1aa 100644 --- a/src/proc/control/command.cpp +++ b/src/proc/control/command.cpp @@ -136,19 +136,6 @@ namespace control { } - /** @todo this is a "nice-to-have"; it would allow to call a function as a command, - * almost as if it was a normal function. But this function needs to be defined - * as a command previously, together with a suitable UNDO function. Moreover - * this would probably require to build an additional index; - * thus this feature is unimplemented for the time being. - */ - Command - Command::get (FuncPtr) - { - UNIMPLEMENTED ("find a command definition which was based on the given function (ptr)"); - } - - /** try to access an existing command definition and immediately * create a new clone copy by calling #newInstance() * @return when search for this ID was successful, a new anonymous diff --git a/src/proc/control/command.hpp b/src/proc/control/command.hpp index 9e9e60845..1a670785a 100644 --- a/src/proc/control/command.hpp +++ b/src/proc/control/command.hpp @@ -133,7 +133,6 @@ namespace control { public: /* === command registry === */ static Command get (Symbol cmdID); - static Command get (FuncPtr func); static bool remove (Symbol cmdID); /** create a clone definition */ diff --git a/tests/core/proc/control/command-use1-test.cpp b/tests/core/proc/control/command-use1-test.cpp index cb8e7d4da..cbc89a356 100644 --- a/tests/core/proc/control/command-use1-test.cpp +++ b/tests/core/proc/control/command-use1-test.cpp @@ -139,10 +139,6 @@ namespace test { invoke ("test.command1.2") (1234); CHECK ( 1234 == command1::check_); - // another shortcut, with static type check: -// invoke (command1::operate) (5678); //////////////////TICKET #291 : unimplemented for now (9/09) -// CHECK ( 1234+5678 == command1::check_); - com.undo(); CHECK ( 0 == command1::check_); }