From da43d7f00f0cbc675468a1aa5e7c6bacad5a49ca Mon Sep 17 00:00:00 2001 From: Ichthyostega Date: Sun, 23 Aug 2015 02:00:33 +0200 Subject: [PATCH] follow-up to the bugfix: just plain int is yet more readable basically the 32/64bit problem was caused by things like 23L, which creates a long. Unfortunately on 64bit platforms, this is aliased to int64_t, while on 32bit i386, it is a distinct data type, but just 32bit, like int. The code in question here is just test / demonstration code and actually just needs "some integer number". So let's stick to good old boring int then. --- tests/15library.tests | 2 +- tests/library/variant-test.cpp | 34 +++++++++++++++++----------------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/tests/15library.tests b/tests/15library.tests index 5c8bc91e6..77b887245 100644 --- a/tests/15library.tests +++ b/tests/15library.tests @@ -598,7 +598,7 @@ END TEST "typesafe Variant record" Variant_test <> TestVariant; + typedef Variant> TestVariant; @@ -88,7 +88,7 @@ namespace test{ { Time someTime; TestVariant v0; - TestVariant v1(int64_t(11)); + TestVariant v1(11); TestVariant v2(string("lololo")); TestVariant v3(someTime); @@ -105,7 +105,7 @@ namespace test{ CHECK (contains (string(v0), "0")); CHECK (contains (string(v1), "Variant")); - CHECK (contains (string(v1), "int64_t") || contains (string(v1), "long") ); + CHECK (contains (string(v1), "int")); CHECK (contains (string(v1), "11")); CHECK (contains (string(v2), "Variant")); @@ -127,15 +127,15 @@ namespace test{ TestVariant v3(someTime); TestVariant v2(someStr); - TestVariant v1 = int64_t(someVal); + TestVariant v1 = someVal; TestVariant v0; v0 = true; CHECK (true == v0.get() ); - CHECK (someVal == v1.get()); + CHECK (someVal == v1.get()); CHECK (someStr == v2.get() ); CHECK (someTime == v3.get