ichthyo/LUMIERA.clone
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

QA: mark all wildcard includes in the GUI code (#1071)

Browse source 
as a rule, one should not rely on "using namespace xyz",
since this makes organisation of minimal header includes near impossible.
You end up with mass includes in some "top level" headers, resulting
in painfully slow compilation turnaround times.

In exceptional cases, using namespace foo might be adequate though
This commit is contained in:
Fischlurch 2017-01-27 22:47:01 +01:00
parent d49983d4cb
commit 0bdc4e1bb4
34 changed files with 70 additions and 70 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/gui/dialog/name-chooser.cpp
View file

@ -25,8 +25,8 @@
#include "gui/dialog/name-chooser.hpp"
#include "gui/dialog/dialog.hpp"
using namespace Gtk;
using namespace Glib;
using namespace Gtk; //////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace Glib; //////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace dialog {

2
src/gui/dialog/preferences-dialog.hpp
View file

@ -44,7 +44,7 @@ namespace dialog {
PreferencesDialog (Gtk::Window &parent)
: Dialog(_("Preferences"), parent, true)
{
using namespace Gtk;
using namespace Gtk; /////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
Box *v_box = get_vbox();
REQUIRE (v_box != NULL);

2
src/gui/dialog/render.cpp
View file

@ -28,7 +28,7 @@
#include "include/logging.h"
using namespace Gtk;
using namespace Gtk; //////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace dialog {

2
src/gui/gtk-lumiera.cpp
View file

@ -39,7 +39,7 @@
namespace gui {
using namespace Gtk; ////////////////////TODO explicit usings please!
using namespace Gtk; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace Glib;
using namespace gui::model;
using namespace gui::workspace;

4
src/gui/model/parent-track.cpp
View file

@ -70,10 +70,10 @@ ParentTrack::remove_descendant_track(
shared_ptr<ParentTrack>
ParentTrack::find_descendant_track_parent(shared_ptr<Track> child)
{
using namespace boost;
using namespace boost; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
REQUIRE(child != NULL);
BOOST_FOREACH(std::shared_ptr<Track> track, tracks)
BOOST_FOREACH(std::shared_ptr<Track> track, tracks) ///////TODO use a standard foreach loop
{
if(track == child)
return shared_from_this();

2
src/gui/panel/panel.cpp
View file

@ -28,7 +28,7 @@
#include <gdl/gdl-dock-item-grip.h>
using namespace Gtk;
using namespace Gtk; //////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace panel{

2
src/gui/panel/timeline-panel-obsolete.cpp
View file

@ -33,7 +33,7 @@
#include <boost/foreach.hpp>
using namespace Gtk;
using namespace Gtk; //////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace sigc;
using namespace gui::widget;
using namespace gui::widget::timeline;

2
src/gui/panel/timeline-panel-obsolete.hpp
View file

@ -42,7 +42,7 @@
#include <memory>
#include <map>
using namespace gui::widget; ////////////TODO only explicit using clauses please!
using namespace gui::widget; /////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace model{

6
src/gui/panel/viewer-panel.cpp
View file

@ -29,9 +29,9 @@
#include "gui/display-service.hpp"
using namespace Gtk;
using namespace gui::widget;
using namespace gui::controller;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::widget; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::controller; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace panel {

6
src/gui/widget/menu-button.cpp
View file

@ -24,9 +24,9 @@
#include "gui/widget/menu-button.hpp"
using namespace Gtk;
using namespace Glib;
using namespace sigc;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace Glib; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace sigc; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
#define POPUP_SLUG "TheMenu"

2
src/gui/widget/menu-button.hpp
View file

@ -31,7 +31,7 @@
namespace gui {
namespace widget {
using namespace Gtk;
using namespace Gtk; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
/**
* A button that displays a menu when clicked on.

10
src/gui/widget/panel-bar.cpp
View file

@ -31,11 +31,11 @@
#include <boost/foreach.hpp>
#include <algorithm>
using namespace Gtk;
using namespace Glib;
using namespace sigc;
using namespace std;
using namespace gui::workspace;
using namespace Gtk; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace Glib; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace sigc; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace std; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::workspace; //////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

2
src/gui/widget/timecode-widget.cpp
View file

@ -49,7 +49,7 @@ using std::string;
namespace gui {
namespace widget {
using namespace Gtk;
using namespace Gtk; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
// TODO: frame rate should not be a constant, but instead be per sequence
const float framerate = 25;

6
src/gui/widget/timeline-widget.cpp
View file

@ -39,10 +39,10 @@ using lib::time::Time;
using lib::time::TimeValue;
using std::dynamic_pointer_cast;
using namespace Gtk;
using namespace Gtk; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace util;
using namespace gui::widget::timeline;
using namespace util; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::widget::timeline; ////////////TODO OK this one looks more sensible, but why do we need to refer to such a nested space so much?
namespace gui {
namespace widget {

6
src/gui/widget/timeline/timeline-body.cpp
View file

@ -33,9 +33,9 @@
#include <cairomm/cairomm.h>
#include <boost/foreach.hpp>
using namespace Gtk;
using namespace std;
using namespace lumiera;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace std; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace lumiera; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using gui::util::CairoUtil;
using std::shared_ptr;

2
src/gui/widget/timeline/timeline-clip-track.cpp
View file

@ -27,7 +27,7 @@
#include <boost/foreach.hpp>
using namespace Gtk;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using std::shared_ptr;
using util::contains;

4
src/gui/widget/timeline/timeline-group-track.cpp
View file

@ -24,8 +24,8 @@
#include "gui/widget/timeline/timeline-group-track.hpp"
#include "gui/widget/timeline-widget.hpp"
using namespace Gtk;
using namespace sigc;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace sigc; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

4
src/gui/widget/timeline/timeline-header-container.cpp
View file

@ -32,8 +32,8 @@
using std::pair;
using std::shared_ptr;
using namespace Gtk;
using namespace util;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace util; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

6
src/gui/widget/timeline/timeline-header-widget.cpp
View file

@ -26,9 +26,9 @@
#include <boost/foreach.hpp>
using namespace Gtk;
using namespace std;
using namespace util;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace std; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace util; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using std::shared_ptr;

2
src/gui/widget/timeline/timeline-ibeam-tool.cpp
View file

@ -25,7 +25,7 @@
#include "gui/widget/timeline-widget.hpp"
#include "lib/time/mutation.hpp"
using namespace gui::widget;
using namespace gui::widget; ///////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using lib::time::Mutation;
using std::shared_ptr;

8
src/gui/widget/timeline/timeline-layout-helper.cpp
View file

@ -36,10 +36,10 @@ using std::shared_ptr;
using std::weak_ptr;
using std::dynamic_pointer_cast;
using namespace Gtk;
using namespace lumiera;
using namespace util;
using namespace gui::util;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace lumiera; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace util; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::util; /////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

10
src/gui/widget/timeline/timeline-ruler.cpp
View file

@ -30,11 +30,11 @@
#include <cairomm/cairomm.h>
using namespace Gtk;
using namespace Cairo;
using namespace gui;
using namespace gui::widget;
using namespace gui::widget::timeline;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace Cairo; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::widget; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::widget::timeline; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using std::shared_ptr;
using gui::util::CairoUtil;

4
src/gui/widget/timeline/timeline-state.cpp
View file

@ -26,8 +26,8 @@
#include "lib/time/mutation.hpp"
#include "lib/time/control.hpp"
using namespace Gtk;
using namespace sigc;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace sigc; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

2
src/gui/widget/timeline/timeline-tool.cpp
View file

@ -24,7 +24,7 @@
#include "gui/widget/timeline/timeline-tool.hpp"
#include "gui/widget/timeline-widget.hpp"
using namespace Gdk;
using namespace Gdk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using std::shared_ptr;
namespace gui {

4
src/gui/widget/timeline/timeline-track.cpp
View file

@ -27,8 +27,8 @@
#include "gui/dialog/name-chooser.hpp"
#include "include/logging.h"
using namespace Gtk;
using namespace sigc;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace sigc; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using std::shared_ptr;

6
src/gui/widget/timeline/timeline-view-window.cpp
View file

@ -25,9 +25,9 @@
#include "gui/widget/timeline-widget.hpp"
using namespace Gtk;
using namespace gui::widget;
using namespace lumiera;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::widget; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace lumiera; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

2
src/gui/widget/timeline/timeline-zoom-scale.cpp
View file

@ -24,7 +24,7 @@
#include "gui/widget/timeline-widget.hpp"
#include "gui/widget/timeline/timeline-zoom-scale.hpp"
using namespace Gtk;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

4
src/gui/widget/timeline/timeline-zoom-scale.hpp
View file

@ -30,8 +30,8 @@
#include "gui/widget/timeline-widget.hpp"
#include "gui/widget/timeline/timeline-state.hpp"
using namespace Gtk;
using namespace gui::widget;
using namespace Gtk; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::widget; ////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

2
src/gui/widget/video-display-widget.hpp
View file

@ -30,7 +30,7 @@
#include "gui/output/displayer.hpp"
using namespace gui::output;
using namespace gui::output; ///////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace widget {

8
src/gui/workspace/actions.cpp
View file

@ -34,10 +34,10 @@
#include "include/logging.h"
using namespace Gtk;
using namespace Glib;
using namespace sigc;
using namespace gui;
using namespace Gtk; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace Glib; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace sigc; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace workspace {

6
src/gui/workspace/panel-manager.cpp
View file

@ -30,9 +30,9 @@
#include "include/logging.h"
using namespace boost;
using namespace std;
using namespace Gtk;
using namespace boost; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace std; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace Gtk; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace workspace {

2
src/gui/workspace/panel-manager.hpp
View file

@ -36,7 +36,7 @@
#include <typeinfo>
using namespace gui::panel;
using namespace gui::panel; ///////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace workspace {

4
src/gui/workspace/workspace-window.cpp
View file

@ -32,8 +32,8 @@
using namespace Gtk;
using namespace Glib;
using namespace Gtk; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace Glib; ////////////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
using namespace gui::model;
using namespace gui::controller;

2
src/gui/workspace/workspace-window.hpp
View file

@ -37,7 +37,7 @@
#include <gtkmm.h>
using namespace gui::panel;
using namespace gui::panel; ///////////////////////////////////////////////////////////////////////////TICKET #1071 no wildcard includes please!
namespace gui {
namespace model {