ichthyo/LUMIERA.clone
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Identified possible GUI shutdown crasher. To be investigated

Browse source 
Our GUI shutdown logic looks rather confused. Why the hell do
some widgets "unregister" themselves in a dtor. This should never
be necessary. Maybe it's a leftover from C-style programming
and obsolete now, after the switch to GDLmm
This commit is contained in:
Fischlurch 2014-10-13 02:44:15 +02:00
parent 1596f83266
commit afaad7044c
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/gui/panels/panel.cpp
View file

@ -66,6 +66,10 @@ Panel::Panel(workspace::PanelManager &panel_manager,
Panel::~Panel()
{
///////////////////////////////////////////////////////TICKET #195 : violation of policy, dtors must not do any work
///////////////////////////////////////////////////////TICKET #172 : observed as a reason for crashes when closing the GUI. It was invoked after end of main, when the GUI as already gone.
#if false /////////////////////////////////////////////////TICKET #937 : disabled for GTK-3 transition. TODO investigate why this logic existed...
/* Detach the panel bar */
GdlDockItemGrip *grip = GDL_DOCK_ITEM_GRIP(
gdl_dock_item_get_grip(dockItem.gobj()));
@ -74,6 +78,7 @@ Panel::~Panel()
/* Remove this panel's container from the DockItem */
dockItem.remove((Gtk::Widget&)*this);
#endif /////////////////////////////////////////////////TICKET #937 : (End)disabled for GTK-3 transition.
}
Gdl::DockItem&