ichthyo/LUMIERA.clone
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clean-up: Bugfixes in passing

Browse source 
Discovered through design-related code analysis
Knowledge-Technology(Claude) spotted discrepancies that led to these fixes.

Remark: the irregular ordering of check predicates stems from the way I developed the logic and bears no meaning.
This commit is contained in:
Fischlurch 2026-09-26 18:22:42 +02:00
parent 0661b27c74
commit f0cdb2f5d2
3 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lib/format-util.hpp
View file

@ -14,7 +14,7 @@
/** @file format-util.hpp
** Collection of small helpers and convenience shortcuts for diagnostics & formatting.
** - util::str() performs a failsafe to-String conversion, thereby preferring a
** - util::toString() performs a failsafe to-String conversion, thereby preferring a
** built-in conversion operator, falling back to just a mangled type string.
** - util::join() generates an enumerating string from elements
** of an arbitrary sequence or iterable. Elements will be passed

6
src/lib/text-template.hpp
View file

@ -542,8 +542,8 @@ namespace lib {
addCode(COND);
break;
case TagSyntax::END_IF:
addLead();
__checkBalanced(IF);
addLead();
if (hasElse())
linkJumpToNext();
else
@ -557,8 +557,8 @@ namespace lib {
addCode(ITER);
break;
case TagSyntax::END_FOR:
addLead();
__checkBalanced(FOR);
addLead();
if (hasElse())
linkJumpToNext();
else
@ -570,9 +570,9 @@ namespace lib {
closeScope();
break;
case TagSyntax::ELSE:
addLead();
__checkInScope();
__checkNoDup();
addLead();
if (IF == scope_.top().clause)
{
markJumpInScope();

14
src/steam/control/command-setup.cpp
View file

@ -175,13 +175,13 @@ namespace control {
Symbol instanceID{prototypeID, invocationID};
Command& instance = table_[instanceID];
if (instance)
throw new error::Logic (_Fmt{"Attempt to create a new Command instance '%s', "
"while an instance for this invocationID %s "
"is currently open for parametrisation and "
"not yet dispatched for execution."}
% instanceID % invocationID
, LERR_(DUPLICATE_COMMAND)
);
throw error::Logic (_Fmt{"Attempt to create a new Command instance '%s', "
"while an instance for this invocationID %s "
"is currently open for parametrisation and "
"not yet dispatched for execution."}
% instanceID % invocationID
, LERR_(DUPLICATE_COMMAND)
);
// create new clone from the prototype
table_[instanceID] = move (Command::get(prototypeID).newInstance());
ENSURE (instance, "cloning of command prototype failed");